Re: odd "rGlyphData.ExtDataRef().mpData != Format::NONE" (vcl/headless/svptext.cxx)

Stephan Bergmann <sbergman -AT- redhat.com>

Fri, 12 Jul 2013 18:57:44 +0200

On 06/20/2013 05:38 PM, Caolán McNamara wrote:

On Thu, 2013-06-20 at 16:15 +0200, Stephan Bergmann wrote:

that might either be a bad way of checking
rGlyphData.ExtDataRef().mpData is non-null that just happens to work out
as intended, or might be a broken attempt at checking that
rGlyphData.ExtDataRef().meInfo is not Format::NONE.

Anybody an idea what might be the better interpretation?


I rather suspect that either is equivalent, I'd vote for meInfo is not
Format::NONE to match the new SvpGcpHelper condition.

But, can you see anyplace where meInfo *or* mpInfo is actually
set/changed away from the ctor defaults of 0, 0. i.e. is it the case
that all the conditionals off ExtGlyphData are constants. And I can't
see anyplace where that pGcpHelper gets deleted (in the normal
condition). The ServerFont::SetExtended call doesn't seem to actually do
anything either.

Indeed, looks like the original code would leak memory. And once you

start to fix that, the existing code goes into double deletes... :)

Hopefully fixed for the better now,

"Fix headless mode glyph cache memory handling."

Stephan

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.