On 12/07/13 10:35, Noel Grandin wrote:
On 2013-07-12 10:35, Noel Power wrote:
Indirectly the the new service migration changes
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fcd01fba69db6de6cfc983fae65b6ba6764de0d6
cause https://bugs.freedesktop.org/show_bug.cgi?id=66586
Eeek. My apologies.
Sometimes I forget to adopt the necessary paranoia when changing
existing code (never assume that existing code actually works, except
in the minimal sense of not producing crashes)
no need to apologise, the change was very sensible, you were just unlucky
A pickaxe search on the git history says that the only commit
containing the string DefaultTreeDataModel is
32cd4a92ef227bacd70be5c325a7e0d82bc90a7e
which introduced the file treecontrolpeer.cxx on the 27 June 2007
So I think it's safe to say that the "DefaultTreeDataModel " service,
if it ever existed, can be considered pre-history.
I think I should simply revert most of the commit, as well as deleting
that chunk of code in
svtools/source/uno/treecontrolpeer.cxx
I think we can revert that whole commit right? it doesn't affect
anything else does it? byt rights we should also delete the call to
createInseance for "com.sun.star.awt.tree.DefaultTreeDataModel" but will
do that separately.
Noel
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.