Hello LibreOffice gerrit bot,
I'd like you to reexamine a change. Please visit
https://gerrit.libreoffice.org/4639
to look at the new patch set (#3).
Change subject: SvStream: remove the error prone operator<</>>(sal_Int64)
......................................................................
SvStream: remove the error prone operator<</>>(sal_Int64)
As the recent regression after merging AOO patch adding code serializing
"long" variables has shown, this overload (which was added in
7b2a0e541567be9750dfc7d98374555967da3470) is a bad idea.
In a unxlngx build, nm finds uses of the symbols _ZN8SvStreamrsERl
and _ZN8SvStreamlsEl in these files:
- sbxvalue.cxx: this appears to be a legitimate use with sal_Int64
- dateitem.cxx: this was accidentally changed by commit
9830fd36dbdb72c79703b0c61efc027fba793c5a
- atrfrm.cxx: this was added for Table Autoformat enhancement in
7e8c0bd73ee59ff3041e55268c77203373962e51, which is after the
sal_Int64 operators were added, so the file format is now
platform dependent
Change-Id: I78352b5429b53612c4831cdb81b587b5de5180a9
---
M basic/source/sbx/sbxvalue.cxx
M include/tools/stream.hxx
M svl/source/items/dateitem.cxx
M sw/source/core/layout/atrfrm.cxx
M tools/source/stream/stream.cxx
5 files changed, 27 insertions(+), 12 deletions(-)
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/4639/3
--
To view, visit https://gerrit.libreoffice.org/4639
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78352b5429b53612c4831cdb81b587b5de5180a9
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl <mstahl@redhat.com>
Gerrit-Reviewer: LibreOffice gerrit bot <gerrit@libreoffice.org>
Gerrit-Reviewer: Luboš Luňák <l.lunak@suse.cz>
Gerrit-Reviewer: Miklos Vajna <vmiklos@suse.cz>
Context
- [PATCH] SvStream: remove the error prone operator<</>>(sal_Int64) · Michael Stahl (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.