Duplicate "Rename Sheet" Entry - What Should be Ranamed and/or Removed? (Previously Re: Code Hint - Removing Dupe Entry in Keyboard Shortcut List)

Hi All,

Thought I would just delete one of these entries but Kohei and Markus 
pointed out that's no good. If you go into customize keyboard in 
Spreadsheet you'll see two entries for "Rename Sheet" -> both appear to 
do the same thing but the unoName does something internally (see Kohei's 
notes below) while the RenameTable is probably correctly marked as 
"Rename Sheet". The code:

http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu#1304 
&

http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu#1312

What can I rename so end user doesn't see the same thing twice. This is 
in reference to: https://bugs.freedesktop.org/show_bug.cgi?id=63965



Thanks!
Joel


On 06/28/2013 07:05 AM, Kohei Yoshida wrote:
> On 06/28/2013 08:34 AM, Markus Mohrhard wrote:
> > Actually these are normally not trivial as they have code indirectly
> > attached to them so you should first check that also the attached
> > actions have the same behavior or are surely unused. Normally the
> > string is mapped to a command id which is then used in the code. For
> > example the .uno:RenameTable can't be deleted because it has a lot of
> > code attached that is necessary. I could not find anything for the
> > .uno:Name command but if you say that it appears in the menu when you
> > delete the string definition there appears to be somewhere a hidden
> > mapping.
>
> .uno:Name is mapped internally to FID_TAB_RENAME which is still very 
> much used.
>
> The way to find out the mapping from an .uno:Foo name to an internal 
> event ID is to look into these .sdi files in sc/sdi/ (without the 
> ".uno:" prefix).  In this case there is this entry
>
> SfxVoidItem RenameTable FID_TAB_MENU_RENAME
> (SfxStringItem Name FID_TAB_RENAME)
> [
> ...
> ]
>
> BTW, I'm not 100% sure how these two are related - the one at the top 
> and the one in the parenthesis. I'm not an expert on this sdi file 
> syntax.
>
> Anyway, even this small hint will hopefully be helpful.
>
> Kohei