Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4323

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/4323/1

fdo#43460 forms: use isEmpty()

Change-Id: If51c22cb28646e7af3785cb086fb4a48af0f7d68
---
M forms/source/xforms/model_ui.cxx
M forms/source/xforms/submission/serialization_urlencoded.cxx
M forms/source/xforms/submission/submission_get.cxx
3 files changed, 3 insertions(+), 3 deletions(-)



diff --git a/forms/source/xforms/model_ui.cxx b/forms/source/xforms/model_ui.cxx
index 7e28623..4dec45b 100644
--- a/forms/source/xforms/model_ui.cxx
+++ b/forms/source/xforms/model_ui.cxx
@@ -219,7 +219,7 @@
          xCurrent = xCurrent->getParentNode() )
     {
         // insert a '/' for every step except the first
-        if( aBuffer.getLength() > 0 )
+        if( !aBuffer.isEmpty() )
             aBuffer.insert( 0, sal_Unicode('/') );
 
         switch( xCurrent->getNodeType() )
diff --git a/forms/source/xforms/submission/serialization_urlencoded.cxx 
b/forms/source/xforms/submission/serialization_urlencoded.cxx
index 0cc80e2..3c85741 100644
--- a/forms/source/xforms/submission/serialization_urlencoded.cxx
+++ b/forms/source/xforms/submission/serialization_urlencoded.cxx
@@ -134,7 +134,7 @@
         }
 
         // found anything?
-        if (aValue.getLength() > 0)
+        if (!aValue.isEmpty())
         {
             OUString aUnencValue = aValue.makeStringAndClear();
             OStringBuffer aEncodedBuffer;
diff --git a/forms/source/xforms/submission/submission_get.cxx 
b/forms/source/xforms/submission/submission_get.cxx
index 62efea1..4698241 100644
--- a/forms/source/xforms/submission/submission_get.cxx
+++ b/forms/source/xforms/submission/submission_get.cxx
@@ -80,7 +80,7 @@
         Sequence< sal_Int8 > aByteBuffer(size);
         while ((n = aInStream->readSomeBytes(aByteBuffer, size-1)) != 0)
             aQueryString.append((sal_Char*)aByteBuffer.getArray(), n);
-        if (aQueryString.getLength() > 0 && m_aURLObj.GetProtocol() != INET_PROT_FILE)
+        if (!aQueryString.isEmpty() && m_aURLObj.GetProtocol() != INET_PROT_FILE)
         {
             aUTF8QueryURL.append('?');
             aUTF8QueryURL.append(aQueryString.makeStringAndClear());

-- 
To view, visit https://gerrit.libreoffice.org/4323
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If51c22cb28646e7af3785cb086fb4a48af0f7d68
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jelle van der Waa <jelle@vdwaa.nl>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.