Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4317
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/4317/1
fdo#43460 configmgr: use isEmpty()
Change-Id: Ifab7cef3e883bc10632ac280ca382b2c68bc79e1
---
M configmgr/source/access.cxx
M configmgr/source/childaccess.cxx
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/configmgr/source/access.cxx b/configmgr/source/access.cxx
index 9f18e8f..1219f37 100644
--- a/configmgr/source/access.cxx
+++ b/configmgr/source/access.cxx
@@ -571,7 +571,7 @@
path.append(root->getAbsolutePathRepresentation());
}
OUString rel(getRelativePathRepresentation());
- if (path.getLength() != 0 && !rel.isEmpty()) {
+ if (!path.isEmpty() && !rel.isEmpty()) {
path.append(sal_Unicode('/'));
}
path.append(rel);
@@ -594,7 +594,7 @@
static_cast< cppu::OWeakObject * >(this), -1);
}
OUStringBuffer path(getRelativePathRepresentation());
- if (path.getLength() != 0) {
+ if (!path.isEmpty()) {
path.append(sal_Unicode('/'));
}
path.append(aRelativeName);
@@ -1873,7 +1873,7 @@
}
if (allChanges != 0) {
OUStringBuffer path(getRelativePathRepresentation());
- if (path.getLength() != 0) {
+ if (!path.isEmpty()) {
path.append(sal_Unicode('/'));
}
path.append(
@@ -1935,7 +1935,7 @@
if (allChanges != 0) {
OUStringBuffer path(
getRelativePathRepresentation());
- if (path.getLength() != 0) {
+ if (!path.isEmpty()) {
path.append(sal_Unicode('/'));
}
path.append(i->first);
@@ -1972,7 +1972,7 @@
if (allChanges != 0) {
OUStringBuffer path(
getRelativePathRepresentation());
- if (path.getLength() != 0) {
+ if (!path.isEmpty()) {
path.append(sal_Unicode('/'));
}
path.append(
diff --git a/configmgr/source/childaccess.cxx b/configmgr/source/childaccess.cxx
index 587f59b..b5a34ef 100644
--- a/configmgr/source/childaccess.cxx
+++ b/configmgr/source/childaccess.cxx
@@ -113,7 +113,7 @@
rtl::Reference< Access > parent(getParentAccess());
if (parent.is()) {
path.append(parent->getRelativePathRepresentation());
- if (path.getLength() != 0) {
+ if (!path.isEmpty()) {
path.append(sal_Unicode('/'));
}
}
--
To view, visit https://gerrit.libreoffice.org/4317
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifab7cef3e883bc10632ac280ca382b2c68bc79e1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jelle van der Waa <jelle@vdwaa.nl>
Context
- [PATCH] fdo#43460 configmgr: use isEmpty() · Jelle van der Waa (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.