Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4306
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/4306/1
fdo#65108 clean-up headers(global/local) perl script
Change-Id: I5f17a33bcd735b4655d350ce8ec2dd069e215a4b
---
A solenv/bin/fix-includes.pl
1 file changed, 95 insertions(+), 0 deletions(-)
diff --git a/solenv/bin/fix-includes.pl b/solenv/bin/fix-includes.pl
new file mode 100755
index 0000000..6460ad2
--- /dev/null
+++ b/solenv/bin/fix-includes.pl
@@ -0,0 +1,95 @@
+#!/usr/bin/perl
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#
+# fix-includes, a simple script replace local includes which should be global
+# , to global includes. And global includes which should be local, to local includes.
+# The script is expected to run in the root of the git repo, so it can fetch all the include
directory's.
+#
+use strict;
+use warnings;
+use File::Basename;
+use File::Find;
+use IO::All;
+
+my $dirname = "include";
+
+# Fetch the list of includes
+my @subdirs = map {basename $_} grep {-d} glob("$dirname/*");
+
+# Add boost
+push(@subdirs,"boost");
+
+# Simple function to check and replace headers
+sub check_headers
+{
+ my ($dir,$file, @includes) = @_;
+ open(my $fh,"+<",$file) or die "Couldn't open file $file $!\n";
+ my @content = <$fh>;
+ my $line;
+
+ # seek to the first line, so we can replace then lines correctly
+ seek $fh,0,0;
+ foreach $line (@content){
+ if($line =~ m/#include "(\w*)\//){
+ # If a include is local and it should be global, make it global
+ if($1 ~~ @includes){
+ print "local header $line\n";
+ $line =~ s/"/</;
+ $line =~ s/"/>/;
+ print $fh $line;
+ print "converted to global header $line\n";
+ }
+ else {
+ print $fh $line;
+ }
+ }
+ # If a local file is defined global, make it local
+ elsif($line =~ /#include <((\w*)\.(hxx|h))>/){
+ # check if file exists, then it must be local so replace the <> to ""
+ if(-e "$dir/$1" ){
+ print "global header $line\n";
+ $line =~ s/</"/g;
+ $line =~ s/>/"/g;
+ print $fh $line;
+ print "converted to local header $line\n";
+ }
+ else {
+ print $fh $line;
+ }
+ }
+ else {
+ print $fh $line;
+ }
+ }
+ close($fh);
+}
+
+# routine that checks the headers of every cxx,hxx,c,h file in a directory
+sub check_routine
+{
+ my ($dir) = @_;
+ opendir(my $fh, $dir) or die "Program stopping, could't open directory \n";
+ while(my $file = readdir($fh)){
+ if($file =~ m/\.(cxx|hxx|c|h)$/i ){
+ check_headers($dir,"$dir/$file",@subdirs);
+ }
+ }
+ closedir($fh);
+}
+
+# Expect ARGV[0] to be a directory, then fetch all subdirectory's and check the header files.
+if(-d $ARGV[0]){
+ my @directories = io->dir($ARGV[0])->All_Dirs;
+ foreach my $dir (@directories){
+ print "checking header files in $dir\n";
+ check_routine($dir);
+ }
+}
+else{
+ print "$ARGV[0] isn't a directory\n";
+}
--
To view, visit https://gerrit.libreoffice.org/4306
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f17a33bcd735b4655d350ce8ec2dd069e215a4b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jelle van der Waa <jelle@vdwaa.nl>
Context
- [PATCH] fdo#65108 clean-up headers(global/local) perl script · Jelle van der Waa (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.