Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4157
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/4157/1
Fix memory leak in SalGtkFilePicker::SalGtkFilePicker.
The result of gtk_widget_create_pango_layout should be unrefed when done.
Change-Id: I46c220a933a2dac42ec21e9e2904938bc4649dbd
---
M vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
1 file changed, 2 insertions(+), 0 deletions(-)
diff --git a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
index 102e16e..7fed719 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
@@ -301,6 +301,8 @@
PangoRectangle row_height;
pango_layout_set_markup (layout, "All Files", -1);
pango_layout_get_pixel_extents (layout, NULL, &row_height);
+ g_object_unref (layout);
+
g_object_get (cell, "ypad", &ypad, (char *)NULL);
guint height = (row_height.height + 2*ypad) * 5;
gtk_widget_set_size_request (m_pFilterView, -1, height);
--
To view, visit https://gerrit.libreoffice.org/4157
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46c220a933a2dac42ec21e9e2904938bc4649dbd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark@klomp.org>
Context
- [PATCH] Fix memory leak in SalGtkFilePicker::SalGtkFilePicker. · Mark Wielaard (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.