Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4154
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/4154/1
FileDialogHelper_Impl::addFilters. Don't leak matcher.
commit 178fc3 removed the creation of filter matcher and explicitly
set mbDeleteMatcher to sal_False. commit 551f85 reintroduced the
matchers, but forgot the remove the explicit setting of mbDeleteMatcher.
Causing mpMatcher to never get deleted even if a new SfxFilterMatcher
was created.
Change-Id: I59f085e1c3ce088f9215be60fb7161364bad0cbe
---
M sfx2/source/dialog/filedlghelper.cxx
1 file changed, 0 insertions(+), 3 deletions(-)
diff --git a/sfx2/source/dialog/filedlghelper.cxx b/sfx2/source/dialog/filedlghelper.cxx
index cc9ada9..c9ab00c 100644
--- a/sfx2/source/dialog/filedlghelper.cxx
+++ b/sfx2/source/dialog/filedlghelper.cxx
@@ -1828,9 +1828,6 @@
TSortedFilterList aIter (xResult);
- // no matcher any longer used ...
- mbDeleteMatcher = sal_False;
-
// append the filters
OUString sFirstFilter;
if (OPEN == lcl_OpenOrSave(m_nDialogType))
--
To view, visit https://gerrit.libreoffice.org/4154
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59f085e1c3ce088f9215be60fb7161364bad0cbe
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark@klomp.org>
Context
- [PATCH] FileDialogHelper_Impl::addFilters. Don't leak matcher. · Mark Wielaard (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.