Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4140
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/4140/1
fix for unused return value.
This code was introduced by:
commit d09dd8986436f17717443823ef18bd8552fdf408
Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com>
Date: Wed Sep 15 13:55:34 2010 +0200
dba34a: export/import min-/max-/default-/value for date/time as
XML-Schema conformant strings
It looks like it intended to use determineDefaultServiceName(), but
neglected to store the return value.
Change-Id: I1607f39cf771b594389492785c7e72478d44843a
---
M xmloff/source/forms/elementimport.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xmloff/source/forms/elementimport.cxx b/xmloff/source/forms/elementimport.cxx
index 9d180b0..443209f 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -184,7 +184,7 @@
}
if ( m_sServiceName.isEmpty() )
- determineDefaultServiceName();
+ m_sServiceName = determineDefaultServiceName();
// create the object *now*. This allows setting properties in the various handleAttribute
methods.
// (Though currently not all code is migrated to this pattern, most attributes are still
handled
--
To view, visit https://gerrit.libreoffice.org/4140
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1607f39cf771b594389492785c7e72478d44843a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Noel Grandin <noelgrandin@gmail.com>
Context
- [PATCH] fix for unused return value. · Noel Grandin (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.