Re: Is HelpId still useful for .src files?

Hey,

2013/5/26 Rodolfo <rodolforg@gmail.com>:
> After see commit 15175a00c976d48f132bc3458e961d1cb2e62a9b [1] "remove
> obsolete helpids and cleanup uiconfig XML",
> I wonder if "helpid" field could be removed also of (popup) menus
> defined in .SRC files.

No. We only removed the old id based help ids that are unused because
the mapping is done by the uno command name.

> Like these cases:
> http://opengrok.libreoffice.org/xref/core/sw/source/ui/inc/toolbox.hrc#34
>
>     ToolBoxItem\
>     {\
>         Identifier = SID_ATTR_CHAR_FONTHEIGHT ; \
>         HelpID = SID_ATTR_CHAR_FONTHEIGHT ; \
>     };\
>
> or
> http://opengrok.libreoffice.org/xref/core/svx/source/fmcomp/gridctrl.src#33
>
>      26 Menu RID_SVXMNU_ROWS
>      27 {
>      28     ItemList =
>      29     {
>      30         MenuItem
>      31         {
>      32             Identifier = SID_FM_DELETEROWS ;
>      33             HelpId = HID_FM_DELETEROWS ;
>      34             Text [ en-US ] = "Delete Rows" ;
>      35         };

The second one is a correct help id as HID_FM_DELETEROWS expands to
SVX_HID_FM_DELETEROWS which can be read by the resource manager and is
mapped to the help text "Deletes the selected record." in english.

The first one is a bit more tricky and I think is missing a help id
nowadays as it is an id based help id which I think has no
representation anymore in the help system. The longer I look at it I
come to the conclusion that the first one is an error. I think it
should be HID_ATTR_CHAR_FONTHEIGHT and that should be mapped to a
correct string and to the correct help text (if there is one at all).

Regards,
Markus