Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4023
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/4023/1
scripting: get CreateUnoDialog() work again
Trivial reproducer:
Dim Dlg As Object
DialogLibraries.LoadLibrary("Standard")
Dlg = CreateUnoDialog(DialogLibraries.Standard.Dialog1)
Dlg.Execute()
Dlg.dispose()
Regression from 6c61b20a8d4a6dcac28801cde82a211fb7e30654.
Change-Id: Ia62778c6d94f54e6097a307701e5c81be847665d
---
M scripting/source/dlgprov/dlgprov.cxx
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripting/source/dlgprov/dlgprov.cxx b/scripting/source/dlgprov/dlgprov.cxx
index 8c645a3..2d96b9d 100644
--- a/scripting/source/dlgprov/dlgprov.cxx
+++ b/scripting/source/dlgprov/dlgprov.cxx
@@ -149,9 +149,10 @@
// Set resource property
if( xStringResourceManager.is() )
{
+ Reference< beans::XPropertySet > xDlgPSet( xDialogModel, UNO_QUERY );
Any aStringResourceManagerAny;
aStringResourceManagerAny <<= xStringResourceManager;
- xDialogModel->setPropertyValue( aResourceResolverPropName, aStringResourceManagerAny );
+ xDlgPSet->setPropertyValue( aResourceResolverPropName, aStringResourceManagerAny );
}
return xDialogModel;
--
To view, visit https://gerrit.libreoffice.org/4023
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia62778c6d94f54e6097a307701e5c81be847665d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Miklos Vajna <vmiklos@suse.cz>
Context
- [PATCH] scripting: get CreateUnoDialog() work again · Miklos Vajna (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.