Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3980
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/3980/1
Fix fdo#64751 – Header & footer blue tags empty
No idea FontMetric::GetHeight() is supposed to mean, probably the code
here meant GetLineHeight(). What it actually need is GetAscent(), so use
it instead (which is the same as GetLineHeight() - GetDescent()).
Change-Id: Ic467e56ed6b8d245ac7800f94e6d40030833328b
---
M sw/source/ui/docvw/HeaderFooterWin.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sw/source/ui/docvw/HeaderFooterWin.cxx b/sw/source/ui/docvw/HeaderFooterWin.cxx
index 970e541..eb88d53 100644
--- a/sw/source/ui/docvw/HeaderFooterWin.cxx
+++ b/sw/source/ui/docvw/HeaderFooterWin.cxx
@@ -291,7 +291,7 @@
GetTextBoundRect( aTextRect, String( m_sLabel ) );
FontMetric aFontMetric = GetFontMetric( GetFont() );
- double nTextOffsetY = aFontMetric.GetHeight() - aFontMetric.GetDescent() + TEXT_PADDING;
+ double nTextOffsetY = aFontMetric.GetAscent() + TEXT_PADDING;
Point aTextPos( TEXT_PADDING, nTextOffsetY );
basegfx::B2DHomMatrix aTextMatrix( createScaleTranslateB2DHomMatrix(
--
To view, visit https://gerrit.libreoffice.org/3980
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic467e56ed6b8d245ac7800f94e6d40030833328b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Khaled Hosny <khaledhosny@eglug.org>
Context
- [PATCH] Fix fdo#64751 – Header & footer blue tags empty · Khaled Hosny (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.