Re: [comment] fdo#37222 and fdo#37219 Open pdf after Export and added to ...

Thanks for the Review .


I have fixed the glitches , you stated in the comments and will submit the
patch .

But , before submitting

I am confused a little bit about the bug 37219 " Add exported PDF files to
recent documents "

that here we are talking about the recent documents of the operating system
(File manager) , not of the LO file menu . Am i right ???

and

in my patch,

if a user Export the PDF and checks View PDF after export , then the file
is opened and it is automatically added to the recent documents of the
Operating System .

but if user doesn't checks View PDF after export, then the file is not
added to recent documents of Operating System.

and in both cases above file is never added to LO recent documents list ,
as a PDF is not opened using LO .

Whether i include bug 37219 fix in my git commit comment or not,  as i
think it is resolved ?

So, please exactly tell me about the bug 37219 .


Thanks


On Fri, May 17, 2013 at 5:26 PM, Thorsten Behrens (via Code Review) <
gerrit@gerrit.libreoffice.org> wrote:

> Thorsten Behrens has posted comments on this change.
>
> Change subject: fdo#37222 and fdo#37219  Open pdf after Export and added
> to recent documents.
> ......................................................................
>
>
> Patch Set 1: This need some tweaks before it is merged
>
> (4 inline comments)
>
> Nice feature! The viewing part works perfectly, some trivial nitpicks in
> the inline comments.
>
> fdo#37219 does not seem fixed though, so better remove the reference from
> the commit comment (or fix it ;))
>
> ....................................................
> File filter/source/pdf/impdialog.src
> Line 313:     };
> Could be moved just a tad up? At least from Impress, there is a larger gap
> from the previous checkbox - or is that intended?
>
>
> ....................................................
> File officecfg/registry/data/org/openoffice/Office/WebWizard.xcu
> Line 209:                     </node>
> What is this for? Seems rather unnecessary?
>
>
> ....................................................
> File vcl/inc/vcl/pdfextoutdevdata.hxx
> Line 112:     sal_Bool    GetIsViewPDF() const;
> What is this (and the SetIsView) for? Seems unused?
>
>
> ....................................................
> File vcl/source/gdi/pdfextoutdevdata.cxx
> Line 555: }
> See question in header
>
>
> --
> To view, visit https://gerrit.libreoffice.org/3810
> To unsubscribe, visit https://gerrit.libreoffice.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Ic94c0a9c6e0f7bef9727a40a8b656218f233cd61
> Gerrit-PatchSet: 1
> Gerrit-Project: core
> Gerrit-Branch: master
> Gerrit-Owner: Anurag Kanungo <anuragkanungo@gmail.com>
> Gerrit-Reviewer: Thorsten Behrens <tbehrens@suse.com>
> Gerrit-Reviewer: Tor Lillqvist <tml@iki.fi>