Re: Compile errors when setting DBG_LEVEL=2

Worked it out - missing brace in an if statement. I was staring at this for
a long time till I decided to remove the conditional defines to make it
compile... then I found it.

I've pushed the fix.

Chris


On Sun, May 12, 2013 at 12:06 PM, Chris Sherlock <chris.sherlock79@gmail.com
> wrote:

> Hey folks,
>
> I'm having tremendous issues with compiling cppcanvas when setting
> DBG_LEVEL=2
>
> Some of these I have fixed in https://gerrit.libreoffice.org/#/c/3861/
>
> However, I can't work out why I get the below errors. When DBG_LEVEL is 1
> then I don't get the errors.
>
> Can anyone shed any light on this? Very grateful to the person who spots
> the issue!!!
>
> Chris Sherlock
>
> chris@LibreOfficeDev:~/repos/LibreOffice/core$ cat ~/error
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:806:28:
> error: non-friend class member 'ReadRectangle' cannot have a qualified name
>         void ImplRenderer::ReadRectangle (SvStream& s, float& x, float& y,
> float &width, float& height, bool bCompressed)
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:821:28:
> error: non-friend class member 'ReadPoint' cannot have a qualified name
>         void ImplRenderer::ReadPoint (SvStream& s, float& x, float& y,
> sal_uInt32 flags)
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:834:28:
> error: non-friend class member 'MapToDevice' cannot have a qualified name
>         void ImplRenderer::MapToDevice (double& x, double& y)
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:841:43:
> error: non-friend class member 'Map' cannot have a qualified name
>         ::basegfx::B2DPoint ImplRenderer::Map (double ix, double iy)
>                             ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:859:42:
> error: non-friend class member 'MapSize' cannot have a qualified name
>         ::basegfx::B2DSize ImplRenderer::MapSize (double iwidth, double
> iheight)
>                            ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:881:28:
> error: non-friend class member 'EMFPPlusFillPolygon' cannot have a
> qualified name
>         void ImplRenderer::EMFPPlusFillPolygon (::basegfx::B2DPolyPolygon&
> polygon, const ActionFactoryParameters& rParms,
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1093:28:
> error: non-friend class member 'EMFPPlusDrawPolygon' cannot have a
> qualified name
>         void ImplRenderer::EMFPPlusDrawPolygon (::basegfx::B2DPolyPolygon&
> polygon, const ActionFactoryParameters& rParms,
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1128:28:
> error: non-friend class member 'processObjectRecord' cannot have a
> qualified name
>         void ImplRenderer::processObjectRecord(SvMemoryStream&
> rObjectStream, sal_uInt16 flags, sal_uInt32 dataSize, sal_Bool
> bUseWholeStream)
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1201:30:
> error: non-friend class member 'setFont' cannot have a qualified name
>         double ImplRenderer::setFont (sal_uInt8 objectId, const
> ActionFactoryParameters& rParms, OutDevState& rState)
>                ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1216:28:
> error: non-friend class member 'GraphicStatePush' cannot have a qualified
> name
>         void ImplRenderer::GraphicStatePush(GraphicStateMap& map,
> sal_Int32 index, OutDevState& rState)
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1236:28:
> error: non-friend class member 'GraphicStatePop' cannot have a qualified
> name
>         void ImplRenderer::GraphicStatePop(GraphicStateMap& map, sal_Int32
> index, OutDevState& rState)
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1253:28:
> error: non-friend class member 'processEMFPlus' cannot have a qualified name
>         void ImplRenderer::processEMFPlus( MetaCommentAction* pAct, const
> ActionFactoryParameters& rFactoryParms,
>              ~~~~~~~~~~~~~~^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:616:77:
> error: expected ';' at end of declaration
>             void Read (SvStream& s, ImplRenderer& rR, sal_Int32, sal_Int32
> )
>
> ^
>
> ;
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:759:48:
> error: call to 'valueOf' is ambiguous
>                         emfp_debug_filename +=
> OUString::valueOf(emfp_debug_stream_number++);
>                                                ^~~~~~~~~~~~~~~~~
> /home/chris/repos/LibreOffice/core/include/rtl/ustring.hxx:2129:62: note:
> candidate function
>     SAL_DEPRECATED_INTERNAL("use boolean()") static OUString valueOf(
> sal_Bool b ) SAL_THROW(())
>                                                              ^
> /home/chris/repos/LibreOffice/core/include/rtl/ustring.hxx:2160:84: note:
> candidate function
>     SAL_DEPRECATED_INTERNAL("convert to OUString or use directly") static
> OUString valueOf( sal_Unicode c ) SAL_THROW(())
>
> ^
> /home/chris/repos/LibreOffice/core/include/rtl/ustring.hxx:2175:61: note:
> candidate function
>     SAL_DEPRECATED_INTERNAL("use number()") static OUString valueOf(
> sal_Int32 i, sal_Int16 radix = 10 ) SAL_THROW(())
>                                                             ^
> /home/chris/repos/LibreOffice/core/include/rtl/ustring.hxx:2190:61: note:
> candidate function
>     SAL_DEPRECATED_INTERNAL("use number()") static OUString valueOf(
> sal_Int64 ll, sal_Int16 radix = 10 ) SAL_THROW(())
>                                                             ^
> /home/chris/repos/LibreOffice/core/include/rtl/ustring.hxx:2204:61: note:
> candidate function
>     SAL_DEPRECATED_INTERNAL("use number()") static OUString valueOf( float
> f ) SAL_THROW(())
>                                                             ^
> /home/chris/repos/LibreOffice/core/include/rtl/ustring.hxx:2218:61: note:
> candidate function
>     SAL_DEPRECATED_INTERNAL("use number()") static OUString valueOf(
> double d ) SAL_THROW(())
>                                                             ^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1942:6:
> error: expected ';' after struct
>     }
>      ^
>      ;
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:1945:52:
> error: expected '}'
> /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
>                                                    ^
> /home/chris/repos/LibreOffice/core/cppcanvas/source/mtfrenderer/emfplus.cxx:96:1:
> note: to match this '{'
> {
> ^
> 16 errors generated.