Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3823
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3823/1
coverity#982460: Explicit null dereferenced
Change-Id: I64d559603bff0d618dce72927566531296984d3c
---
M l10ntools/source/xrmmerge.cxx
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/l10ntools/source/xrmmerge.cxx b/l10ntools/source/xrmmerge.cxx
index 8a8b856..8265b4a 100644
--- a/l10ntools/source/xrmmerge.cxx
+++ b/l10ntools/source/xrmmerge.cxx
@@ -381,11 +381,10 @@
sFilename( rFilename ) ,
pResData( NULL )
{
- if (!rMergeSource.isEmpty())
+ if (!rMergeSource.isEmpty() && sLanguage.equalsIgnoreAsciiCase("ALL"))
+ {
pMergeDataFile = new MergeDataFile(
rMergeSource, sInputFileName, false);
- if( sLanguage.equalsIgnoreAsciiCase("ALL") )
- {
aLanguages = pMergeDataFile->GetLanguages();
}
else
--
To view, visit https://gerrit.libreoffice.org/3823
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64d559603bff0d618dce72927566531296984d3c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412@yahoo.fr>
Context
- [PATCH] coverity#982460: Explicit null dereferenced · Julien Nabet (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.