Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hello

In Makefile.in, we enforce bash with SHELL=/usr/bin/env bash, but we state that the build should be posix enabled (at least I was told that :)) , so why not SHELL=/usr/bin/env sh or SHELL=/bin/sh (or nothing, since latter is default) ? I understand that some scripts still need bash, but they have the right shebang line and SHELL will be the default shell used by $(shell...) command, no ?
Moreover, in Makefile.gbuild we have :
ifdef gb_SHELL
SHELL := $(gb_SHELL)
else
SHELL := /bin/sh
endif
So SHELL in global makefile is only used for sources.ver from tarball and to echo the version to sed, so we can :
- remove the SHELL assignment in Makefile.in
- remove the else part of the ifdef in Makefile.gbuild

regards
--
Mat M

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.