Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3657
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/3657/1
change order to allow validation of chart part
My simple test file is finally valid but is still now shown in Excel.
There must be another bug in our exporter.
Change-Id: Ib55e5b32edc3a556e9081b3008df539275dc289b
(cherry picked from commit e81d0c400c02a87d7fa492dbc5ac9f7921167920)
---
M oox/source/export/chartexport.cxx
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx
index 37abe5d..5211a76 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -2187,6 +2187,9 @@
XML_val, sTickLblPos,
FSEND );
+ // shape properties
+ exportShapeProps( xAxisProp );
+
pFS->singleElement( FSNS( XML_c, XML_crossAx ),
XML_val, I32S( aAxisIdPair.nCrossAx ),
FSEND );
@@ -2281,8 +2284,6 @@
FSEND );
}
- // shape properties
- exportShapeProps( xAxisProp );
// TODO: text properties
pFS->endElement( FSNS( XML_c, nAxisType ) );
--
To view, visit https://gerrit.libreoffice.org/3657
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib55e5b32edc3a556e9081b3008df539275dc289b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard <markus.mohrhard@googlemail.com>
Context
- [PATCH libreoffice-4-0] change order to allow validation of chart part · Markus Mohrhard (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.