Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3651
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/3651/1
Fixing Indentation RTL bug
Change-Id: Ie8c3d30cb28afb97d4ded4ac67241ed18ab9e50c
---
M writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index 81ac271..0a0b63e 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -1609,7 +1609,19 @@
if (mpValue.get() == NULL)
{
- OOXMLValue::Pointer_t pValue(new OOXMLIntegerValue(0));
+ // Value should not always be 'true'
+ //OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(true));
+ bool bSet = true;
+
+ // Paragraph properties are not always 'true' by default
+ // For example - RTL layout of paragraph is by default 'false' (look in this link for
'sprmPFBiDi')
+ // http://msdn.microsoft.com/en-us/library/dd923496%28v=office.12%29.aspx
+ if (getId() == 0x2441)
+ {
+ bSet = false;
+ }
+
+ OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(bSet));
setValue(pValue);
}
}
--
To view, visit https://gerrit.libreoffice.org/3651
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8c3d30cb28afb97d4ded4ac67241ed18ab9e50c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Adam Co <rattles2013@gmail.com>
Context
- [PATCH] Fixing Indentation RTL bug · Adam Co (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.