Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3616
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/3616/1
Change j type to size_t
Change-Id: If04e33228162baab392906903a574f1a6e7a6110
---
M connectivity/source/drivers/postgresql/pq_connection.cxx
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/connectivity/source/drivers/postgresql/pq_connection.cxx
b/connectivity/source/drivers/postgresql/pq_connection.cxx
index f0d9e03..4f830a1 100644
--- a/connectivity/source/drivers/postgresql/pq_connection.cxx
+++ b/connectivity/source/drivers/postgresql/pq_connection.cxx
@@ -496,8 +496,7 @@
for( int i = 0; i < args.getLength() ; ++i )
{
bool append = false;
-// for( int j = 0; j < (int) ( sizeof( keyword_list ) / sizeof( char * )); j++)
- for( int j = 0; j < (int) SAL_N_ELEMENTS( keyword_list ); j++)
+ for( size_t j = 0; j < SAL_N_ELEMENTS( keyword_list ); j++)
{
if( args[i].Name.equalsIgnoreAsciiCaseAscii( keyword_list[j] ))
{
@@ -505,7 +504,6 @@
append = true;
break;
}
- append = false;
}
if( append )
--
To view, visit https://gerrit.libreoffice.org/3616
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If04e33228162baab392906903a574f1a6e7a6110
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anthony Youngman <anthony@youngman.org.uk>
Context
- [PATCH] Change j type to size_t · Anthony Youngman (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.