Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Vishv Brahmbhatt wrote:
I am hereby attaching my patch for review.

Hi Vishv,

wow, impressive work - compiles & works mostly fine here!!

Two things - there's a lot of whitespace change in your patch, and
also some trailing whitespace on some lines (the git commit hooks
complain about it) - could you clean that up?

And then, loading and saving this new field does not yet work. I think
the relevant code lives here:

 xmloff/source/text/txtfld{ei}.cxx

The scripting/workben/bindings/impressmenubar.xml change, you can just
skip, that seems example code.

As an extra, it seems changing the slide name does not update the
field content, possibly some
Broadcast(SfxSimpleHint(SFX_HINT_DATACHANGED)) or somesuch missing at
a strategic place? Of course, happy to merge w/o, and/or help with
tracking that nit down. :)

Also there is new file created
@offapi/com/sun/star/text/textfield/SlideName.idl for the patch. So I am
attaching that file too.

You can just git add offapi/com/sun/star/text/textfield/SlideName.idl
it, will then be included in your subsequent commit.

Cheers,

-- Thorsten

Attachment: signature.asc
Description: Digital signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.