Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3546
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3546/1
Replace chained O(U)StringBuffer::append() with operator+
modified: basctl/source/basicide/basides2.cxx
Change-Id: I681188553058ac8712365bc2de39b0453fd19ed9
---
M basctl/source/basicide/basides2.cxx
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/basctl/source/basicide/basides2.cxx b/basctl/source/basicide/basides2.cxx
index e08fe95..8e1daa8 100644
--- a/basctl/source/basicide/basides2.cxx
+++ b/basctl/source/basicide/basides2.cxx
@@ -111,19 +111,15 @@
if ( !m_aCurLibName.isEmpty() )
{
LibraryLocation eLocation = m_aCurDocument.getLibraryLocation( m_aCurLibName );
- aTitleBuf.append(m_aCurDocument.getTitle(eLocation));
- aTitleBuf.append('.');
- aTitleBuf.append(m_aCurLibName);
+ aTitleBuf = m_aCurDocument.getTitle(eLocation) + "." + m_aCurLibName ;
}
else
- aTitleBuf.append(IDE_RESSTR(RID_STR_ALL));
+ aTitleBuf = IDE_RESSTR(RID_STR_ALL) ;
DocumentSignature aCurSignature( m_aCurDocument );
if ( aCurSignature.getScriptingSignatureState() == SIGNATURESTATE_SIGNATURES_OK )
{
- aTitleBuf.append(' ');
- aTitleBuf.append(IDE_RESSTR(RID_STR_SIGNED));
- aTitleBuf.append(' ');
+ aTitleBuf = aTitleBuf + " " + IDE_RESSTR(RID_STR_SIGNED) + " ";
}
OUString aTitle(aTitleBuf.makeStringAndClear());
--
To view, visit https://gerrit.libreoffice.org/3546
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I681188553058ac8712365bc2de39b0453fd19ed9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anurag Kanungo <anuragkanungo@gmail.com>
Context
- [PATCH] Replace chained O(U)StringBuffer::append() with operator+ · Anurag Kanungo (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.