Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3538

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3538/1

bDocumentDone is always false

Change-Id: Ifde4d9235d3eacf0317b19885f5ea57e1c695cb3
---
M editeng/source/misc/hangulhanja.cxx
1 file changed, 2 insertions(+), 3 deletions(-)



diff --git a/editeng/source/misc/hangulhanja.cxx b/editeng/source/misc/hangulhanja.cxx
index a1493fe..4f7189a 100644
--- a/editeng/source/misc/hangulhanja.cxx
+++ b/editeng/source/misc/hangulhanja.cxx
@@ -535,9 +535,8 @@
     bool HangulHanjaConversion_Impl::ContinueConversion( bool _bRepeatCurrentUnit )
     {
         bool bNeedUserInteraction = false;  // when we leave here, do we need user interaction?
-        bool bDocumentDone = false;         // did we already check the whole document?
 
-        while ( !bDocumentDone && !bNeedUserInteraction && implNextConvertible( 
_bRepeatCurrentUnit ) )
+        while ( !bNeedUserInteraction && implNextConvertible( _bRepeatCurrentUnit ) )
         {
             OUString sCurrentUnit( GetCurrentUnit() );
 
@@ -581,7 +580,7 @@
             }
         }
 
-        return  bDocumentDone || !bNeedUserInteraction;
+        return !bNeedUserInteraction;
     }
 
     bool HangulHanjaConversion_Impl::implGetConversionDirectionForCurrentPortion( 
HHC::ConversionDirection& rDirection )

-- 
To view, visit https://gerrit.libreoffice.org/3538
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifde4d9235d3eacf0317b19885f5ea57e1c695cb3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matteo Casalin <matteo.casalin@gmx.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.