Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3523

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/3523/1

Changed a few compareTo's to '=='

Change-Id: I0a0ba87ec517e5dd776ab45b232dd7f227451466
---
M ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx
M xmlhelp/source/cxxhelp/provider/databases.hxx
2 files changed, 3 insertions(+), 3 deletions(-)



diff --git a/ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx 
b/ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx
index 0f10513..0ec097c 100644
--- a/ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx
@@ -135,7 +135,7 @@
             if ( !aValue.isEmpty() )
             {
                 aValue = stripDavNamespace( aValue ).toAsciiLowerCase();
-                if ( aValue.compareTo( "<collection" ) == 0 )
+                if ( aValue == "<collection" )
                 {
                     thePropertyValue.Value
                         <<= OUString("collection");
diff --git a/xmlhelp/source/cxxhelp/provider/databases.hxx 
b/xmlhelp/source/cxxhelp/provider/databases.hxx
index 905c86c..8585700 100644
--- a/xmlhelp/source/cxxhelp/provider/databases.hxx
+++ b/xmlhelp/source/cxxhelp/provider/databases.hxx
@@ -156,7 +156,7 @@
         {
             bool operator()( const OUString& rKey1, const OUString& rKey2 ) const
             {
-                return rKey1.compareTo( rKey2 ) == 0;
+                return (rKey1 == rKey2);
             }
         };
 
@@ -351,7 +351,7 @@
         {
             bool operator()( const OString& rKey1, const OString& rKey2 ) const
             {
-                return rKey1.compareTo( rKey2 ) == 0;
+                return (rKey1 == rKey2);
             }
         };
 

-- 
To view, visit https://gerrit.libreoffice.org/3523
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a0ba87ec517e5dd776ab45b232dd7f227451466
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Sameer Deshmukh <sameer.deshmukh93@gmail.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.