Re: [PATCH] BUG#62096 Replace O(U)String compareTo with ==

Janit Anjaria <janit92 -AT- gmail.com>
Sat, 20 Apr 2013 01:32:11 +0530

Hey!
I am hereby submitting my patches for review.


Regards,
Janit


On Sat, Apr 20, 2013 at 12:53 AM, Eike Rathke <erack@redhat.com> wrote:

Hi Janit,

On Friday, 2013-04-19 02:09:55 +0530, Janit Anjaria wrote:

-    if ( 0 == PropertyName.compareTo( FM_PROP_TEXTLINECOLOR ) )
+    if ( PropertyName == ( FM_PROP_TEXTLINECOLOR ) )


Same nitpick as in my previous mail, please remove the now extraneous ()

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n
transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software!
https://fsfe.org/support/?erack

Attachment: 0001-fdo-62096-Replace-O-U-String-compareTo-with.patch
Description: Binary data

Context

[PATCH] BUG#62096 Replace O(U)String compareTo with == · Janit Anjaria
- Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · Eike Rathke
  - Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · Janit Anjaria
    - Re: [PUSHED] BUG#62096 Replace O(U)String compareTo with == · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.