Re: [Libreoffice-commits] core.git: sfx2/inc sfx2/source

On 2013-04-17 10:06, Miklos Vajna wrote:
> On Tue, Apr 16, 2013 at 01:04:46PM -0700, Noel Grandin <noel@peralex.com> wrote:
> >   sfx2/inc/sfx2/dispatch.hxx       |    4 +
> >   sfx2/source/control/dispatch.cxx |   99 ++++++++++++++++++---------------------
> >   2 files changed, 49 insertions(+), 54 deletions(-)
> >
> > New commits:
> > commit 7e4db91a3900fd0bbce0f0592a045458a37862b3
> > Author: Noel Grandin <noel@peralex.com>
> > Date:   Mon Apr 15 11:21:16 2013 +0200
> >
> >      Convert SfxShellStack_Impl from SfxPtrArr to std::vector
> >      
> >      Change-Id: I1ffd615a505029242a87337c9ef42c8156c42d70
> >      Reviewed-on: https://gerrit.libreoffice.org/3394
> After this commit, I see some new warnings on startup:
>
> warn:legacy.tools:27529:1:sfx2/source/control/dispatch.cxx:1592: pushed SfxShell already on stack
>
> Reverting this commit (to test, you need to also revert
> 187a592df9bc9c1ef4b53fe6dce40a3c74f6bb67 and
> e2ce3538943c510efa8041fca3c83728acf3a155, but they are unlikely to be
> reason for this) makes the warning go away. I did not look into this
> deeply, is it possible that the old container checked if the given
> SfxShell is already on the stack, and if so, it didn't add it?

Aaah, sorry about that, I got the DBG_ASSERT the wrong way around.
Pushed a fix - c3b1ce2097ea3b43234be3dfb1d529335b980ff8



Disclaimer: http://www.peralex.com/disclaimer.html