Re: [PATCH] BUG#62096 Replace O(U)String compareTo with ==

Stephan Bergmann <sbergman -AT- redhat.com>
Tue, 16 Apr 2013 15:00:40 +0200

On 04/15/2013 03:19 PM, Janit Anjaria wrote:

I am hereby attaching my patch for fdo #62096 :

https://bugs.freedesktop.org/show_bug.cgi?id=62096

Any suggestions would be great to be implemented.


First, note that

  s.compareTo(t) != 0

is /not/ the same as

  s == t

Second, did you build and test your change? It looks likesal/qa/rtl/process/child_process.cxx is one of those rotting tests thatis not built nor executed, not even with a top-level "make check".

Also, please take care not to mess up the indentation of lines, makingthe "if" indented only three instead of four spaces.


Stephan

Context

[PATCH] BUG#62096 Replace O(U)String compareTo with == · Janit Anjaria
- Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · Stephan Bergmann
  - (message not available)
    - Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · Janit Anjaria
      - Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · JorenDC
        
        Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · Janit Anjaria
      - Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · Eike Rathke
        
        Re: [PATCH] BUG#62096 Replace O(U)String compareTo with == · Janit Anjaria
        
        Re: [PUSHED] BUG#62096 Replace O(U)String compareTo with == · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.