Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

On Tuesday, 2013-04-09 18:05:18 +0530, Prashant Pandey wrote:

---------- Forwarded message ----------
From: Prashant Pandey <prashant3.yishu@gmail.com>
Date: Tue, Apr 9, 2013 at 3:27 AM
Subject: discrepancy regarding fdo#61541
To: erack@redhat.com, michael.meeks@suse.com

For the records, attached is the answer I wrote..

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
--- Begin Message ---
Hi Prashant,

On Tuesday, 2013-04-09 03:27:15 +0530, Prashant Pandey wrote:

Following the code pointers, if I do the changes in accordance with bug
report in https://bugs.freedesktop.org/show_bug.cgi?id=61541#c4, after
changing ScColumn::UpdateSelectionFunction() and
ScColumn::UpdateAreaFunction() as suggested, the behaviour of 'Selection
count' is exactly same as the behaviour of 'aCount', i.e. whenever some
data is in the cell, only then the increment is done and no change is
reflected if the cell is empty (has no data).

That is because you only increment the count for cells that actually
have data. ScColumn::maItems contains only cells with data. So for the
selection count you need to not iterate over maItems (using
ScMarkedDataIter in ScColumn::UpdateSelectionFunction() or the loop in
ScColumn::UpdateAreaFunction()), but instead evaluate the selection in
rMark for that column in ScColumn::UpdateSelectionFunction(),
respectively in ScColumn::UpdateAreaFunction() count nEndRow-nStartRow+1
minus the hidden rows.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

Attachment: pgpCV2rCIR4pk.pgp
Description: PGP signature


--- End Message ---

Attachment: pgp9JY9oB2bKt.pgp
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.