Hi, On Tuesday, 2013-04-09 18:05:18 +0530, Prashant Pandey wrote:
---------- Forwarded message ---------- From: Prashant Pandey <prashant3.yishu@gmail.com> Date: Tue, Apr 9, 2013 at 3:27 AM Subject: discrepancy regarding fdo#61541 To: erack@redhat.com, michael.meeks@suse.com
For the records, attached is the answer I wrote.. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A For key transition see http://erack.de/key-transition-2013-01-10.txt.asc Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
--- Begin Message ---
- Eike Rathke <erack -AT- redhat.com>
- Tue, 9 Apr 2013 16:31:15 +0200
Hi Prashant, On Tuesday, 2013-04-09 03:27:15 +0530, Prashant Pandey wrote:Following the code pointers, if I do the changes in accordance with bug report in https://bugs.freedesktop.org/show_bug.cgi?id=61541#c4, after changing ScColumn::UpdateSelectionFunction() and ScColumn::UpdateAreaFunction() as suggested, the behaviour of 'Selection count' is exactly same as the behaviour of 'aCount', i.e. whenever some data is in the cell, only then the increment is done and no change is reflected if the cell is empty (has no data).That is because you only increment the count for cells that actually have data. ScColumn::maItems contains only cells with data. So for the selection count you need to not iterate over maItems (using ScMarkedDataIter in ScColumn::UpdateSelectionFunction() or the loop in ScColumn::UpdateAreaFunction()), but instead evaluate the selection in rMark for that column in ScColumn::UpdateSelectionFunction(), respectively in ScColumn::UpdateAreaFunction() count nEndRow-nStartRow+1 minus the hidden rows. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A For key transition see http://erack.de/key-transition-2013-01-10.txt.asc Support the FSFE, care about Free Software! https://fsfe.org/support/?erackAttachment: pgpCV2rCIR4pk.pgp
Description: PGP signature
--- End Message ---
Attachment:
pgp9JY9oB2bKt.pgp
Description: PGP signature