Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Janit Anjaria wrote:
I am hereby attaching my patch on fdo#57950 where the .append() calls are
replaced by  + operator.

Hi Janit,

this does not seem to be a patch against master - the code there has
OUStringBuffer sBuffer etc etc, not OUString sBuffer as required by
your patch. Please squash your various changes you did to that file
into one commit, see e.g.
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Cheers,

-- Thorsten

Attachment: signature.asc
Description: Digital signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.