Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hey Thorsten,Stefan ,

I just saw the patch,yes it definitely need clean up based on the white
spaces ,and yeah the numbers in the patch are added so that the UI fixes
right and hence the toolbar appears to be right.I am not sure about the
reason why the icons dont appear in your case,as it does appear when i run
the code on my machine.

And regarding the following:
debug: max width 388
      debug: max width 78
      debug: max width 55
      [...]
This is just an output for the debugging i had done for the UI purpose and
yeah it would be fine,i would get that part of the code out.

Regards,
Janit


On Tue, Apr 9, 2013 at 8:09 AM, Janit Anjaria <janit92@gmail.com> wrote:

Hey Thorsten,Stefan ,

I just saw the patch,yes it definitely need clean up based on the white
spaces ,and yeah the numbers in the patch are added so that the UI fixes
right and hence the toolbar appears to be right.I am not sure about the
reason why the icons dont appear in your case,as it does appear when i run
the code on my machine.

And regarding the following:
debug: max width 388
      debug: max width 78
      debug: max width 55
      [...]
This is just an output for the debugging i had done for the UI purpose and
yeah it would be fine,i would get that part of the code out.

Regards,
Janit


On Tue, Apr 9, 2013 at 3:54 AM, Thorsten Behrens <
thb@documentfoundation.org> wrote:

Janit Anjaria wrote:
I am hereby submitting my patch for review on the bug/feature which i
had
worked long back which solves the problem where the comboboxes now do
appear when the toolbar is vertical.

Hi Janit,

the patch contains a lot of changes ala

     if ( eAlign == WINDOWALIGN_TOP )
     {
-        rLeft   = borderwidth+dragwidth;
+        rLeft   = borderwidth+dragwidth-150;
         rTop    = borderwidth;

 - where do those numbers come from; as Astron points out, it breaks
more than it fixes?

Also, please remove unrelated whitespace / formatting changes, ala

         {
             pThis->mpData->mbAssumeDocked = sal_True;   // force
non-floating mode during calculation
-            ImplCalcBorder( WINDOWALIGN_LEFT, nLeft, nTop, nRight,
nBottom, pThis );
+           ImplCalcBorder( WINDOWALIGN_LEFT, nLeft, nTop, nRight,
nBottom, pThis );

, or submit it separately (the example above though really makes
matters worse, not better).

Please spend a bit of time on reviewing / cleaning up your patch
submissions *before* mailing them out. This increases your chances of
getting useful and timely feedback.

Cheers,

-- Thorsten




Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.