Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On 04/04/2013 15:21, Caolán McNamara wrote:
On Tue, 2013-04-02 at 14:13 -0700, julien2412 wrote:
...
Cppcheck reported this:
sfx2/source/doc/docfile.cxx
2626    redundantAssignment     style   Variable 'nEncoding' is reassigned a value
before the old one has been used.
...
I took a look to the git history but it's quite confusing. Moreover UTF8
doesn't appear in the switch some lines below.
back before b1ec4b2cd5a9e6ece0e2a928cc0a11fef6bbe818 there was a bMSType
argument which protected the switch so it wasn't redundant back then.

Looks like the remaining first branch "aka writer" means in practice the
ms .doc format, and the other is the .xls format.

Using the system encoding is rather foul looking to me but if that's the
way it has "always" been done I'm comfortable enough just changing the
code to be ...

rtl_TextEncoding nEncoding = osl_getThreadTextEncoding();
Thank you Caolán for your feedback! I pushed the change on master sources (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=7dce1c9fd2d26c9c2c53f0d307aa281972d2e82d)

Julien

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.