Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3167

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3167/1

remove unused code.

A request (rReq) having anyone of following SID
SID_ATTR_CHAR_FONTHEIGHT, SID_ATTR_CHAR_FONT,SID_ATTR_CHAR_COLOR
doesn’t have a NULL pArgs .

that’s why execution control never enters into
"drtxtob1.cxx:349 -> if( !pArgs )" block of code
for a request (rReq) having anyone of mentioned SIDs.

Change-Id: I77945dd81108b3e0d3282fa7547311868f0bafae
---
M sd/source/ui/view/drtxtob1.cxx
1 file changed, 0 insertions(+), 32 deletions(-)



diff --git a/sd/source/ui/view/drtxtob1.cxx b/sd/source/ui/view/drtxtob1.cxx
index 4163ff1..e8e1179 100644
--- a/sd/source/ui/view/drtxtob1.cxx
+++ b/sd/source/ui/view/drtxtob1.cxx
@@ -476,38 +476,6 @@
                         aNewAttr.Put( aItem );
                     }
                     break;
-
-                    // attributes for TextObjectBar
-                    case SID_ATTR_CHAR_FONT:
-                    {
-                        if( pArgs )
-                        {
-                            if( SFX_ITEM_SET == pArgs->GetItemState( EE_CHAR_FONTINFO, sal_True, 
&pPoolItem ) )
-                                aNewAttr.Put( *pPoolItem );
-                        }
-                        else
-                            mpViewShell->GetViewFrame()->GetDispatcher()->
-                            Execute( SID_CHAR_DLG, SFX_CALLMODE_ASYNCHRON );
-                    }
-                    break;
-                    case SID_ATTR_CHAR_FONTHEIGHT:
-                    {
-                        if( pArgs )
-                        {
-                            if( SFX_ITEM_SET == pArgs->GetItemState( EE_CHAR_FONTHEIGHT, sal_True, 
&pPoolItem ) )
-                                aNewAttr.Put( *pPoolItem );
-                        }
-                        else
-                            mpViewShell->GetViewFrame()->GetDispatcher()->
-                            Execute( SID_CHAR_DLG, SFX_CALLMODE_ASYNCHRON );
-                    }
-                    break;
-                    case SID_ATTR_CHAR_COLOR:
-                    {
-                        if( pArgs && SFX_ITEM_SET == pArgs->GetItemState( EE_CHAR_COLOR, sal_True, 
&pPoolItem ) )
-                            aNewAttr.Put( *pPoolItem );
-                    }
-                    break;
 // #i35937# removed need for FN_NUM_BULLET_ON handling
                 }
 

-- 
To view, visit https://gerrit.libreoffice.org/3167
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77945dd81108b3e0d3282fa7547311868f0bafae
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: navin patidar <patidar@kacst.edu.sa>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.