Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3080

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/3080/1

stop uninitialized memory leaking into resource files.

Change-Id: I8659426dd4ea0c13c8ed839ef5cfb686e6648042
---
M rsc/source/tools/rsctools.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/rsc/source/tools/rsctools.cxx b/rsc/source/tools/rsctools.cxx
index 02507cc..a9dfb1b 100644
--- a/rsc/source/tools/rsctools.cxx
+++ b/rsc/source/tools/rsctools.cxx
@@ -377,7 +377,10 @@
 char * RscWriteRc :: GetPointer( sal_uInt32 nSize )
 {
     if( !pMem )
+    {
         pMem = (char *)rtl_allocateMemory( nLen );
+        memset( pMem, 0, nLen );
+    }
     return( pMem + nSize );
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/3080
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8659426dd4ea0c13c8ed839ef5cfb686e6648042
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Andras Timar <atimar@suse.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.