Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On 24/03/13 23:34, Stephan Bergmann wrote:
So, is it still useful or could we remove BASH check and OOO_SHELL as
well ?

I'm not sure I understand your question.  The LO build system requires 
Bash in places, esp. as the shell used to execute makefile recipe lines. 

gbuild should only require /bin/sh (which is faster unless it's a
symlink to bash).

(That said, it looks like OOO_SHELL is actually unused since we got rid 
of the old dmake-based build system, and could be dropped.  The use of 
Bash in gbuild is enforced via "SHELL=/usr/bin/env bash" in Makefile.mk, 
which should arguably be replaced with "SHELL=@BASH@".)

this is overridden by solenv/gbuild/gbuild.mk:

ifdef gb_SHELL
SHELL := $(gb_SHELL)
else
SHELL := /bin/sh
endif

i don't know what needs the "SHELL=bash" in top-level makefile but
perhaps there's still some script somewhere... perhaps it would be less
confusing to add a "#!/bin/bash" to any script that needs it instead?



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.