Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2929
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2929/1
Related coverity#441160 Logically dead code
Change-Id: Ibb4cff2b9a53eb1d9f4ea6043ed2b1b2deba1e2b
---
M filter/source/graphicfilter/epict/epict.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/filter/source/graphicfilter/epict/epict.cxx
b/filter/source/graphicfilter/epict/epict.cxx
index 26a2bf3..4114cdb 100644
--- a/filter/source/graphicfilter/epict/epict.cxx
+++ b/filter/source/graphicfilter/epict/epict.cxx
@@ -657,7 +657,7 @@
dh = aPoint.X()-aDstTextPosition.X();
dv = aPoint.Y()-aDstTextPosition.Y();
- if (bDstTextPositionValid==sal_False || dh<0 || dh>255 || dv<0 || dv>0 || bDelta==sal_False)
+ if (bDstTextPositionValid==sal_False || dh<0 || dh>255 || dv<0 || dv>255 || bDelta==sal_False)
{
*pPict << (sal_uInt16)0x0028;
WritePoint(rPoint);
--
To view, visit https://gerrit.libreoffice.org/2929
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb4cff2b9a53eb1d9f4ea6043ed2b1b2deba1e2b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412@yahoo.fr>
Context
- [PATCH] Related coverity#441160 Logically dead code · Julien Nabet (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.