Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2766
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2766/1
coverity#738979 Use after free
Change-Id: I843556f18542ac601fd7e16c6f51218ef913de31
---
M svx/source/gallery2/galtheme.cxx
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx
index 0afd03e..952898b 100644
--- a/svx/source/gallery2/galtheme.cxx
+++ b/svx/source/gallery2/galtheme.cxx
@@ -604,11 +604,11 @@
if( pEntry->bDummy )
{
Broadcast( GalleryHint( GALLERY_HINT_CLOSE_OBJECT, GetName(), reinterpret_cast<
sal_uIntPtr >( pEntry ) ) );
+ Broadcast( GalleryHint( GALLERY_HINT_OBJECT_REMOVED, GetName(), reinterpret_cast<
sal_uLong >( pEntry ) ) );
GalleryObjectList::iterator it = aObjectList.begin();
::std::advance( it, i );
aObjectList.erase( it );
delete pEntry;
- Broadcast( GalleryHint( GALLERY_HINT_OBJECT_REMOVED, GetName(), reinterpret_cast<
sal_uLong >( pEntry ) ) );
}
else ++i;
}
--
To view, visit https://gerrit.libreoffice.org/2766
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I843556f18542ac601fd7e16c6f51218ef913de31
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412@yahoo.fr>
Context
- [PATCH] coverity#738979 Use after free · Julien Nabet (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.