Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2761
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/2761/1
Return true or false instead of a 1 or 0 in this function
Change-Id: I223a342aa9496674714929e0dc78bc53b30273a2
---
M sw/source/ui/docvw/PostItMgr.cxx
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sw/source/ui/docvw/PostItMgr.cxx b/sw/source/ui/docvw/PostItMgr.cxx
index 1a7c063..1b6531d 100644
--- a/sw/source/ui/docvw/PostItMgr.cxx
+++ b/sw/source/ui/docvw/PostItMgr.cxx
@@ -87,9 +87,9 @@
using namespace sw::sidebarwindows;
+// sort depending on position
bool comp_pos(const SwSidebarItem* a, const SwSidebarItem* b)
{
- // sort by anchor position
SwPosition aPosAnchorA = a->GetAnchorPosition();
SwPosition aPosAnchorB = b->GetAnchorPosition();
@@ -106,11 +106,11 @@
// if AnchorA is in footnote, and AnchorB isn't
// we do not want to change over the position
if( aAnchorAInFooter && !aAnchorBInFooter )
- return 0;
+ return false;
// if aAnchorA is not placed in a footnote, and aAnchorB is
// force a change over
else if( !aAnchorAInFooter && aAnchorBInFooter )
- return 1;
+ return true;
// if none of both, or both are in the footer
// arrange them depending on the position
else
--
To view, visit https://gerrit.libreoffice.org/2761
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I223a342aa9496674714929e0dc78bc53b30273a2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper <joren.libreoffice@telenet.be>
Context
- [PATCH] Return true or false instead of a 1 or 0 in this function · Joren De Cuyper (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.