Julien Nabet wrote:
I noticed several things:
1) we could replace "if (pText1)" by "if (pNewText)". Of course if blocks
must be changed
2) if pText1 corresponds to a new OutlinerParaObject and !pText, it seems
there's a leak
Yeps.
3) why pObj->ActionChanged() and ImpShowPageOfThisObject() are always
called ?
I would not suggest relying on that - this code has some serious 15+
years of bugfix sedimentation behind it. If you've played some
multiple hours with your fix in, and understood the code flow, go for
it - otherwise, don't take chances. ;)
Cheers,
-- Thorsten
Attachment:
signature.asc
Description: Digital signature
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.