Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2608

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2608/1

Documentation to avoid a real use-after-free bug

Change-Id: Ie8a4432b0a70703fbfe92480ad0608b659a887d0
---
M svtools/source/contnr/treelist.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/svtools/source/contnr/treelist.cxx b/svtools/source/contnr/treelist.cxx
index 307d861..55beae9 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -1268,6 +1268,9 @@
 
 void SvListView::ModelHasRemoved( SvTreeListEntry* )
 {
+    //WARNING WARNING WARNING
+    //The supplied pointer should have been deleted
+    //before this call. Be careful not to use it!!!
     DBG_CHKTHIS(SvListView,0);
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/2608
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8a4432b0a70703fbfe92480ad0608b659a887d0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marc-André Laverdière <marc-andre@atc.tcs.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.