Re: [PATCH] fdo#60148 Clean up warnings from the Clang compiler plugin

All of my past & future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license.

On 03/04/2013 06:20 PM, Cao Cuong Ngo (via Code Review) wrote:
> Hi,
>
> I have submitted a patch for review:
>
>     https://gerrit.libreoffice.org/2544
>
> To pull it, you can do:
>
>     git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/2544/1
>
> fdo#60148 Clean up warnings from the Clang compiler plugin
>
> Cleaned all the warnings from loplugin. Some warnings come from the untar downloaded sources 
> couldn't be fixed.
>
> Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
> ---
> M UnoControls/source/base/registercontrols.cxx
> M accessibility/source/extended/accessibleeditbrowseboxcell.cxx
> M autodoc/source/parser_i/idoc/cx_dsapi.cxx
> M basegfx/source/polygon/b2dpolygontools.cxx
> M basegfx/source/polygon/b3dpolypolygontools.cxx
> M basic/source/runtime/iosys.cxx
> M basic/source/sbx/sbxobj.cxx
> M basic/source/sbx/sbxvalue.cxx
> M chart2/source/controller/dialogs/tp_DataSource.cxx
> M chart2/source/controller/main/ChartDropTargetHelper.cxx
> M chart2/source/controller/main/ChartFrameloader.cxx
> M chart2/source/model/template/BarChartTypeTemplate.cxx
> M chart2/source/model/template/ChartTypeTemplate.cxx
> M connectivity/source/commontools/dbtools2.cxx
> M connectivity/source/drivers/file/FTable.cxx
> M connectivity/source/drivers/mork/MResultSetMetaData.cxx
> M connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx
> M connectivity/source/drivers/postgresql/pq_xtable.cxx
> M connectivity/source/drivers/postgresql/pq_xtables.cxx
> M connectivity/source/drivers/postgresql/pq_xuser.cxx
> M connectivity/source/parse/sqlnode.cxx
> M cppcanvas/source/mtfrenderer/emfplus.cxx
> M cui/source/dialogs/cuigaldlg.cxx
> M cui/source/tabpages/tpbitmap.cxx
> M cui/source/tabpages/tpgradnt.cxx
> M cui/source/tabpages/tphatch.cxx
> M cui/source/tabpages/tplnedef.cxx
> M desktop/source/app/lockfile2.cxx
> M drawinglayer/source/geometry/viewinformation2d.cxx
> M drawinglayer/source/geometry/viewinformation3d.cxx
> M drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx
> M drawinglayer/source/primitive3d/sdrextrudeprimitive3d.cxx
> M drawinglayer/source/primitive3d/sdrlatheprimitive3d.cxx
> M editeng/source/misc/hangulhanja.cxx
> M filter/source/config/cache/filterfactory.cxx
> M filter/source/graphicfilter/icgm/class2.cxx
> M filter/source/placeware/exporter.cxx
> M filter/source/xsltdialog/xmlfiltertabpagexslt.cxx
> M forms/source/xforms/datatypes.cxx
> M formula/source/ui/dlg/funcpage.cxx
> M framework/source/services/autorecovery.cxx
> M helpcompiler/source/HelpCompiler.cxx
> M hwpfilter/source/hwpreader.cxx
> M i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
> M idl/source/prj/command.cxx
> M jvmfwk/source/elements.cxx
> M l10ntools/source/xrmmerge.cxx
> M lotuswordpro/source/filter/lwpoleobject.cxx
> M padmin/source/adddlg.cxx
> M reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
> M rsc/source/rscpp/cpp5.c
> M sal/inc/sal/log-areas.dox
> M sc/qa/unit/helper/qahelper.hxx
> M sc/qa/unit/subsequent_export-test.cxx
> M sc/qa/unit/subsequent_filters-test.cxx
> M sc/source/core/tool/compiler.cxx
> M sc/source/filter/oox/extlstcontext.cxx
> M sc/source/ui/drawfunc/drawsh.cxx
> M sc/source/ui/pagedlg/scuitphfedit.cxx
> M sc/source/ui/vba/vbafont.cxx
> M sd/source/filter/eppt/pptx-epptooxml.cxx
> M sfx2/source/appl/appuno.cxx
> M sfx2/source/appl/linksrc.cxx
> M sfx2/source/control/bindings.cxx
> M sfx2/source/control/dispatch.cxx
> M sfx2/source/control/shell.cxx
> M sfx2/source/dialog/dinfdlg.cxx
> M sfx2/source/dialog/filedlghelper.cxx
> M sfx2/source/doc/sfxbasemodel.cxx
> M sfx2/source/menu/mnuitem.cxx
> M sfx2/source/view/sfxbasecontroller.cxx
> M slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx
> M slideshow/source/engine/transitions/fanwipe.cxx
> M svtools/source/contnr/DocumentInfoPreview.cxx
> M svx/source/dialog/srchdlg.cxx
> M svx/source/fmcomp/gridcell.cxx
> M svx/source/form/navigatortree.cxx
> M svx/source/gallery2/galobj.cxx
> M svx/source/sdr/primitive2d/sdrprimitivetools.cxx
> M unotools/source/config/configitem.cxx
> M vcl/source/filter/wmf/enhwmf.cxx
> M vcl/source/gdi/pdfwriter_impl.cxx
> M vcl/source/window/window.cxx
> M vcl/unx/generic/printer/printerinfomanager.cxx
> M vcl/unx/gtk/fpicker/SalGtkFolderPicker.cxx
> M writerperfect/source/draw/WPGImportFilter.cxx
> 86 files changed, 1,510 insertions(+), 1,624 deletions(-)