Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2548

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/2548/1

resolved rhbz#916936 allow also input line for read-only

Allow activation of input line and cell activation in read-only
documents regardless whether it's part of an array or not.

Change-Id: Id2dc9de9e60b58f4b471fb232e899c9ea75e83f1
(cherry picked from commit 9c51646541846317777b00dc6ad2e30cb1c07950)
---
M sc/source/ui/app/inputhdl.cxx
1 file changed, 6 insertions(+), 4 deletions(-)



diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 727799a..3ec6bcf 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -1962,10 +1962,12 @@
         if (!aTester.IsEditable())
         {
             bProtected = true;
-            // We allow read-only input mode activation when explicit cell
-            // activation is requested (double-click or F2) and if it's not
-            // part of an array.
-            bool bShowError = !bInputActivated || aTester.GetMessageId() != STR_PROTECTIONERR;
+            // We allow read-only input mode activation regardless
+            // whether it's part of an array or not or whether explicit cell
+            // activation is requested (double-click or F2) or a click in input
+            // line.
+            bool bShowError = (!bInputActivated || aTester.GetMessageId() != STR_PROTECTIONERR) &&
+                !pActiveViewSh->GetViewData()->GetDocShell()->IsReadOnly();
             if (bShowError)
             {
                 eMode = SC_INPUT_NONE;

-- 
To view, visit https://gerrit.libreoffice.org/2548
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2dc9de9e60b58f4b471fb232e899c9ea75e83f1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Eike Rathke <erack@redhat.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.