[PATCH libreoffice-4-0] resolved rhbz#916936 allow also input line for read-only

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2546

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/2546/1

resolved rhbz#916936 allow also input line for read-only

Allow activation of input line and cell activation in read-only
documents regardless whether it's part of an array or not.

Change-Id: Id2dc9de9e60b58f4b471fb232e899c9ea75e83f1
(cherry picked from commit 9c51646541846317777b00dc6ad2e30cb1c07950)
---
M sc/source/ui/app/inputhdl.cxx
1 file changed, 6 insertions(+), 4 deletions(-)



diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 6938e0d..11cca6d 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -1950,10 +1950,12 @@
         if (!aTester.IsEditable())
         {
             bProtected = true;
-            // We allow read-only input mode activation when explicit cell
-            // activation is requested (double-click or F2) and if it's not
-            // part of an array.
-            bool bShowError = !bInputActivated || aTester.GetMessageId() != STR_PROTECTIONERR;
+            // We allow read-only input mode activation regardless
+            // whether it's part of an array or not or whether explicit cell
+            // activation is requested (double-click or F2) or a click in input
+            // line.
+            bool bShowError = (!bInputActivated || aTester.GetMessageId() != STR_PROTECTIONERR) &&
+                !pActiveViewSh->GetViewData()->GetDocShell()->IsReadOnly();
             if (bShowError)
             {
                 eMode = SC_INPUT_NONE;

-- 
To view, visit https://gerrit.libreoffice.org/2546
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2dc9de9e60b58f4b471fb232e899c9ea75e83f1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Eike Rathke <erack@redhat.com>