Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

Hey Eric,


> I have added my first real code for submission to LO :-) It's in gerrit:
> https://gerrit.libreoffice.org/2476.

I'm going to review it in the next days.

> I looked on the LO website to find some pointers around in the code, but
> didn't really found it. My main helpers were OpenGrok and gdb. Did I miss a
> nice overview of where to find which functionality ?

No. There is no real documentation. As you already discovered xmloff/
contains the ODF import and export code for charts and chart2 the
whole implementation for the chart code. Additionally oox/ contains
the OOXML import and export code for charts.


> Secondly, what would you recommend as a primer on the C++ functionalities
> used in LO code + how they are used ? I didn't do that advanced C++ coding
> before that I know a lot about templates and namespaces.

It very much depends on your knowledge.


> I also want to add some debug code in what I have done, mainly to print a
> warning if new curve types are fed to LO. What's the best way to do that ?
> From
> https://wiki.documentfoundation.org/Development/How_to_debug#Macros_Controlling_Debug_Code
> I would think to add the code in #ifdef SAL_LOG_WARN or use the SAL_WARN
> macro.

You should use SAL_WARN and SAL_INFO for these tasks. Additionally we
are using more and more assert if we really want an abort for a
special condition. THere is also SAL_WARN_IF and SAL_INFO_IF for
conditional debug statements.

> Anyway, I will now create a mock for the UI and discuss this on the UI list.
> Once this is done, what would be the best way to add the new UI
> functionality ? A friendly push in the right direction would save me quite
> some time ;-)

You should design the dialogs nowadays with Glade. We are switching
from our old dialog descriptions to new glade xml files. Caolan wrote
a nice wiki page about widgetllayout
(https://wiki.documentfoundation.org/Development/WidgetLayout). While
it focuses mostly on transfering old dialogs to the new format it
should give you a basic idea how to create a new one. If you need one
of the custom widgets that we have somewhere in the code or other
customization of an existing widget we can help you implement that.

Thanks a lot for your great work on this feature.

Regards,
Markus