Hi Urs,
On Fri, 2013-03-01 at 12:05 +0100, Urs Fässler wrote:
Translation of german comments in sd/inc and sd/sdi
Wow - this is some great work ! thanks so much for that :-) I'll send
an individual [PUSHED] mail to each of yours for tracking [I'm up to
commit 18]; but overall this looks great.
A small number of these patches failed - where the work had been
duplicated by someone else: patches 3->7 and 14 in the first 18 - which
is a shame. Are you updating to the latest git before working ? [ that
can be hard with conflicts of course ]. One quick/easy way to resolve
that is:
git pull -r
<git rebase --skip> # until the rebase is complete
Otherwise - this is great; one thing that would make the code cleaner
and more readable is when you have things like;
+++ b/sd/source/core/pglink.cxx
@@ -54,7 +54,7 @@ SdPageLink::~SdPageLink()
/*************************************************************************
|*
-|* Daten haben sich geaendert
+|* Date have changed
|*
\************************************************************************/
If you could remove the big & bulky ascii-art surround - that is of no
real use to a developer and just wastes v-space - that would be a nice
cleanup: but if you want to focus on just the content that's fine too.
Also - another thing is if you find:
/* This method makes spaghetti */
void makeSpaghetti()
feel free to just kill it - it adds no value ;-)
one last thing is - if we have a nice function description:
/* Un-twist the general bottle-tops at high-speed backwards */
void untwistFast()
It's great to turn it into a doxygen comment thus:
/// Un-twist the general bottle-tops at high-speed backwards
void untwistFast()
So it will get sucked out into our web docs.
Anyhow - thanks for the encouraging work, moving on to the next set
now. [ Oh, and - if you can push more a handful of file at once as a
commit that is prolly a good thing to do too to reduce mailing list and
git commit churn ;-].
Thanks !
Michael.
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.