Re: [RESOLVED] fdo#36668 - Add image captions above the image

On Thu, 2013-01-03 at 12:35 +0100, Bartosz wrote:
> Hi.
> I would like to start work on fdo#36668 Possibility to add image captions above the image.
>
> Writer allows captions of tables above or below the table.
> If someone want to add a caption to an image, the option "position" is always "Below".
> More info (with screenshots) is available at:
> https://bugs.freedesktop.org/show_bug.cgi?id=36668
>
> Do you know where image insertion (especially position) is implemented?
> Where should I start looking for?

Because I fairly recently converted that caption dialog to the new
widget layout I was in that code area recently. Anyway...
a) to find the code for something visible in the UI search for the
string in http://opengrok.libreoffice.org/ That'll find you the .src
or .ui where the string is and then it's a matter of grepping for the
name of the surrounding .ui or dialog/tabpage of the .src in the source
to find where it's implemented. In this case it's
sw/source/ui/frmdlg/cption.cxx
b) Turns out to be trivial to fix this, the fundamental bug appears that
the original code put the orientation as the first argument to the
orientation class and not the *second*. Fixed as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a9c14730d93ea434cb456d248c37c7ff41fa6c0

C.