Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On Wed, 2012-12-19 at 15:00 -0800, julien2412 wrote:
Hello,

Cppcheck detected this into svx/source/svdraw/svdoedge.cxx
[svdoedge.cxx:1450]: (style) Variable 'pPt1' is assigned a value that is
never used.
[svdoedge.cxx:1453]: (style) Variable 'pPt4' is assigned a value that is
never used

That SdrEdgeObj::ImpCalcEdgeTrack is one of the most unpleasantly long
and unreadable things I've seen in LibreOffice.

Either pPt1 and pPt4 assignations may really be removed or a change must be
done here.

git blame && show on results indicate it's there since initial
OOo-ification in 2000. It looks like a dead loss to me to do anything
except remove the assignations that have no utility.

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.