Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2156
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/2156/1
fdo#35365 Set the default font color to black and the document color to white.
The font and document color of a Writer document or an Impress presentation
should not be derived from a desktop theme. A Writer documents needs to look
good on paper. An Impress presentation may have it's own theme. The appearance
of a document should not change by changing the desktop theme.
With this change a document looks the same on any computer if the user do not
change the default colors.
Change-Id: Ia42ca7882f0d2dd1f2a304db5e4b5aaba23244fc
---
M svtools/source/config/colorcfg.cxx
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/svtools/source/config/colorcfg.cxx b/svtools/source/config/colorcfg.cxx
index abdb852..4f899af 100644
--- a/svtools/source/config/colorcfg.cxx
+++ b/svtools/source/config/colorcfg.cxx
@@ -412,12 +412,12 @@
{
static const sal_Int32 aAutoColors[] =
{
- 0, // DOCCOLOR
+ COL_WHITE, // DOCCOLOR
0xc0c0c0, // DOCBOUNDARIES
0x808080, // APPBACKGROUND
0xc0c0c0, // OBJECTBOUNDARIES
0xc0c0c0, // TABLEBOUNDARIES
- 0, // FONTCOLOR
+ COL_BLACK, // FONTCOLOR
0xcc, // LINKS
0x80, // LINKSVISITED
0xff0000, // SPELL
@@ -462,16 +462,8 @@
Color aRet;
switch(eEntry)
{
- case DOCCOLOR :
- aRet = Application::GetSettings().GetStyleSettings().GetWindowColor();
- break;
-
case APPBACKGROUND :
aRet = Application::GetSettings().GetStyleSettings().GetWorkspaceColor();
- break;
-
- case FONTCOLOR :
- aRet = Application::GetSettings().GetStyleSettings().GetWindowTextColor();
break;
case LINKS :
--
To view, visit https://gerrit.libreoffice.org/2156
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia42ca7882f0d2dd1f2a304db5e4b5aaba23244fc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Context
- [PATCH libreoffice-3-6] fdo#35365 Set the default font color to black and the docume... · via Code Review
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.