Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hello,

Il 13/02/2013 15:24, julien2412 ha scritto:
Hello,

Cppcheck reported this:
sc/source/ui/view/tabview2.cxx
970     unreadVariable  style   Variable 'bMark' is assigned a value that is never
used.    951 void ScTabView::PaintBlock( bool bReset )
[snip]

See
http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/tabview2.cxx#950

Is line 970 can be removed or is something lacking?

It looks to me like this and other cppcheck errors you have reported on list follow the pattern "let's update the variable because in theory if i ever need to use it again the old value would be wrong". But practice is a different matter :)

Also while we are speaking about code checkers is anyone looking at coverity scan? On a couple of projects I've found it reporting ten time the errors reported by cppcheck.

thanks,
riccardo

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.