Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi Peter,

Thanks, it was a good fix, I did the same for all CustomActions. Just
one more problem: now MSVCRT is linked dinamically. It is not good,
because MSVCRT is not part of the default Windows installation. We
need to link it statically like we did that before.

Thanks,
Andras


On Mon, Feb 11, 2013 at 11:03 PM, Peter Foley <pefoley2@verizon.net> wrote:
Andras,

I just pushed a patch that should fix it.
Could you test it?

Thanks,

Peter

-----Original Message----- From: Andras Timar Sent: Monday, February 11,
2013 7:37 AM To: Peter Foley Cc: libreoffice Subject: Re: [PATCH] convert
setup_native to gbuild and add to tail_build
Hi Peter,

On Sat, Feb 9, 2013 at 3:54 PM, Peter Foley (via Code Review)
<gerrit@gerrit.libreoffice.org> wrote:

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2063


I tested you patch and it does not work for me.
Windows Installer cannot execure any of the CustomActions. E.g.:
MSI (c) (9C:B0) [13:23:41:427]: Invoking remote custom action. DLL:
C:\Users\timar\AppData\Local\Temp\MSIAF36.tmp, Entrypoint:
SelectLanguage
CustomAction SelectLanguage returned actual error code 1154 but will
be translated to success due to continue marking
The problem is that in newly built DLLs the names are mangled, I see
_SelectLanguage@4 instead of SelectLanguage in Dependency Walker.

Best regards,
Andras

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.