Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hello,

Cppcheck reported this:
drawinglayer/source/primitive2d/sceneprimitive2d.cxx
196     unreadVariable  style   Variable 'fViewSizeX' is assigned a value that is
never used.
197     unreadVariable  style   Variable 'fViewSizeY' is assigned a value that is
never used.    193                     if(fReducedVisualisationFactor !=
1.0)
    194                     {
    195                         fReduceFactor *=
fReducedVisualisationFactor;
    196                         fViewSizeX *= fReducedVisualisationFactor;
    197                         fViewSizeY *= fReducedVisualisationFactor;
    198                     }
    199                 }

see
http://opengrok.libreoffice.org/xref/core/drawinglayer/source/primitive2d/sceneprimitive2d.cxx#192

Indeed, after these lines, fViewSizeX and fViewSizeY are no more used.
It's been like this since 2009-10-20 (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a0a3168f4354285e59dd79d4477a4199c2f773b) 
Should we remove the lines 196 and 197 or is something lacking?


Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-reports-fViewSizeX-fViewSizeY-are-assigned-a-value-never-used-drawingplayer-part-tp4036929.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.